Fix for NullReferenceException in lazy bidirectional many-to-one properties #52
Conversation
|
@dennis-gr @maca88 First PR since #50 was merged. do you see any obvious reason why generateasynccode.yml failed here? Seems like a path is wrong. |
Yeah, the paths in AsyncGenerator.yml contain a backslash instead of a slash. Should I create a PR for this or can you edit the file? |
|
thanks for you reply @dennis-gr. updated here 01dd4478e358c72b7f550c8f3df5ca7be39205e5 @DavidUv - can you integrate this PR with latest master and give it a new shot, please? |
|
It seems to pass now but I accidentally created a merge instead of a rebase. Should I close this PR and create a new one based on the latest master? |
|
yeah, do that if you want to. and if you do, please avoid the added/removed spaces changes made in AuditEventListener. Hard to see the actual change. thanks |
Having a many-to-one bidirectional mapping with lazy properties will result in a
NullReferenceExceptioninAuditEventListener. This change to theAuditEventListenerwill fix this. There is also an accompanying unit test for this.The underlying problem that triggered the
NullReferenceExceptionwas due to the fact that the entity name could not be resolved since it was not of the expected type. The type in the case of a lazy property is a<entity name>ProxyForFieldInterceptorand not the actual type of the entity. Using the NHibernate utility methodBestGuessEntityNamewill resolve to the actual entity name thus satisfying the mapping in Envers.As I am not familiar to the Envers code base I tried to keep the
AuditEventListenerchanges minimal not to disturb the functionality. All tests passes and this fixes the problem but I'm not totally sure how the mapping actually works and thevalueargument is still of theProxyForFieldInterceptortype. Could this be a problem?